Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_config_setting_private_default_visibility will break rules_dotnet in Bazel 7.0 #333

Closed
keertk opened this issue Jan 30, 2023 · 0 comments · Fixed by #334

Comments

@keertk
Copy link
Member

keertk commented Jan 30, 2023

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_dotnet. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#12933.

Please check the following CI builds for build and test results:

E.g.

(01:13:35) INFO: ToolchainResolution: Target platform @buildkite_config//config:platform: Selected execution platform @buildkite_config//config:platform, type @rules_dotnet//dotnet:toolchain_type -> toolchain @dotnet_x86_64-unknown-linux-gnu//:dotnet_toolchain
--
  | (01:13:35) INFO: ToolchainResolution: Target platform @buildkite_config//config:platform: Selected execution platform @buildkite_config//config:platform,
  | (01:13:35) INFO: ToolchainResolution: Target platform @buildkite_config//config:platform: Selected execution platform @buildkite_config//config:platform,
  | (01:13:35) INFO: ToolchainResolution: Target platform @buildkite_config//config:platform: Selected execution platform @buildkite_config//config:platform,
  | (01:13:35) ERROR: /var/lib/buildkite-agent/builds/bk-docker-bx9x/bazel-downstream-projects/rules_dotnet/examples/diamond/BUILD.bazel:32:15: in csharp_library rule //diamond:Bottom: target '@rules_dotnet//dotnet/private:linux-x64' is not visible from target '//diamond:Bottom'. Check the visibility declaration of the former target if you think the dependency is legitimate
  | (01:13:35) ERROR: /var/lib/buildkite-agent/builds/bk-docker-bx9x/bazel-downstream-projects/rules_dotnet/examples/diamond/BUILD.bazel:32:15: in csharp_library rule //diamond:Bottom: target '@rules_dotnet//dotnet/private:linux-arm64' is not visible from target '//diamond:Bottom'. Check the visibility declaration of the former target if you think the dependency is legitimate
  | (01:13:35) ERROR: /var/lib/buildkite-agent/builds/bk-docker-bx9x/bazel-downstream-projects/rules_dotnet/examples/diamond/BUILD.bazel:32:15: in csharp_library rule //diamond:Bottom: target '@rules_dotnet//dotnet/private:macos-x64' is not visible from target '//diamond:Bottom'. Check the visibility declaration of the former target if you think the dependency is legitimate
  | (01:13:35) ERROR: /var/lib/buildkite-agent/builds/bk-docker-bx9x/bazel-downstream-projects/rules_dotnet/examples/diamond/BUILD.bazel:32:15: in csharp_library rule //diamond:Bottom: target '@rules_dotnet//dotnet/private:macos-arm64' is not visible from target '//diamond:Bottom'. Check the visibility declaration of the former target if you think the dependency is legitimate
  | (01:13:35) ERROR: /var/lib/buildkite-agent/builds/bk-docker-bx9x/bazel-downstream-projects/rules_dotnet/examples/diamond/BUILD.bazel:32:15: in csharp_library rule //diamond:Bottom: target '@rules_dotnet//dotnet/private:windows-x64' is not visible from target '//diamond:Bottom'. Check the visibility declaration of the former target if you think the dependency is legitimate
  | (01:13:35) ERROR: /var/lib/buildkite-agent/builds/bk-docker-bx9x/bazel-downstream-projects/rules_dotnet/examples/diamond/BUILD.bazel:32:15: in csharp_library rule //diamond:Bottom: target '@rules_dotnet//dotnet/private:windows-arm64' is not visible from target '//diamond:Bottom'. Check the visibility declaration of the former target if you think the dependency is legitimate
  | (01:13:35) ERROR: /var/lib/buildkite-agent/builds/bk-docker-bx9x/bazel-downstream-projects/rules_dotnet/examples/diamond/BUILD.bazel:32:15: Analysis of target '//diamond:Bottom' failed
  | (01:13:35) ERROR: Analysis of target '//diamond:Bottom' failed; build aborted:
  | (01:13:35) INFO: Elapsed time: 0.744s
  | (01:13:35) INFO: 0 processes.
  | (01:13:35) ERROR: Build did NOT complete successfully

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

purkhusid added a commit that referenced this issue Jan 30, 2023
purkhusid added a commit that referenced this issue Jan 30, 2023
* Make compatible with Bazel 7.0

## What?
Closes #333 and #322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant