Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules_go provides no bzl_library targets #2619

Closed
aherrmann opened this issue Aug 24, 2020 · 1 comment · Fixed by #2621
Closed

rules_go provides no bzl_library targets #2619

aherrmann opened this issue Aug 24, 2020 · 1 comment · Fixed by #2621
Labels
code-health enhancement

Comments

@aherrmann
Copy link

What version of rules_go are you using?

v0.23.8

What version of gazelle are you using?

none

What version of Bazel are you using?

3.3.1

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

Ubuntu 20.04 x86_64

Any other potentially useful information about your toolchain?

n/a

What did you do?

I've defined a stardoc target for a rule set that itself uses rules_go. The stardoc rule has a deps attribute that expects bzl_library targets. The transitive closure of the deps attribute must cover all *.bzl files that are loaded directly or indirectly by the rules to be documented. rules_go does not expose a bzl_library attribute, hence I cannot specify it as a dependency on my use-case and cannot generate Stardoc documentation for my use-case.

What did you expect to see?

That rules_go defines a bzl_library target for rules_go that includes all relevant .bzl files.

What did you see instead?

That rules_go defines no bzl_library target.
@aherrmann aherrmann mentioned this issue Aug 24, 2020
Closed
achew22 added a commit to achew22/rules_go that referenced this issue Aug 24, 2020
@achew22
Create bzl_library entries using gazelle-skylark
97ba01f 
There are a few minor manual modifications that needed to be performed.
For example, some `.bzl` files depend on `.bzl` files that are generated
outside of this repo and do not presently exist. `@bazel_tools` is a
great example of this.

Additionally this effort has revealed that bazel gazelle has an explicit
dependency on the private parts of rules_go in
internal/gazelle_binary.bzl on line 21 where it imports from
`go/private:rules/transitions.bzl` which is no longer the path to import
from once I created the BUILD file in `go/private/rules`.

As a temporary fix for this, I'm included a patch that changes that to
point to the new path. I will provide a follow up patch once rules_go
has been released to fix it properly in the gazelle repo and then remove
the patch from rules_go.

Fixed: bazelbuild#2619
Bug: bazelbuild/bazel-skylib#250
Bug: bazelbuild/bazel-gazelle#803
@achew22 achew22 mentioned this issue Aug 24, 2020
Merged
@jayconrod
Copy link
Contributor

I generally agree we should do this.

I think this is best implemented using the new bzl extension for Gazelle. To the extent possible, these targets should be automatically maintained and should follow conventions. For that reason, I'd prefer to go with #2621. It looks like there are still some kinks to work out in the Gazelle extension though.

Both of these PRs are significant changes right before a release, so this won't make it into v0.24.0.

@achew22 achew22 mentioned this issue Aug 24, 2020
Closed
achew22 added a commit to achew22/rules_go that referenced this issue Aug 27, 2020
@achew22 @aherrmann
Create bzl_library entries using gazelle-skylark
5536b1e 
There are a few minor manual modifications that needed to be performed.
For example, some `.bzl` files depend on `.bzl` files that are generated
outside of this repo and do not presently exist. `@bazel_tools` is a
great example of this.

Additionally this effort has revealed that bazel gazelle has an explicit
dependency on the private parts of rules_go in
internal/gazelle_binary.bzl on line 21 where it imports from
`go/private:rules/transitions.bzl` which is no longer the path to import
from once I created the BUILD file in `go/private/rules`.

As a temporary fix for this, I'm included a patch that changes that to
point to the new path. I will provide a follow up patch once rules_go
has been released to fix it properly in the gazelle repo and then remove
the patch from rules_go.

Fixed: bazelbuild#2619
Bug: bazelbuild/bazel-skylib#250
Bug: bazelbuild/bazel-gazelle#803
Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
achew22 added a commit to achew22/rules_go that referenced this issue Aug 27, 2020
@achew22 @aherrmann
Create bzl_library entries using gazelle-skylark
8e545b0 
There are a few minor manual modifications that needed to be performed.
For example, some `.bzl` files depend on `.bzl` files that are generated
outside of this repo and do not presently exist. `@bazel_tools` is a
great example of this.

Additionally this effort has revealed that bazel gazelle has an explicit
dependency on the private parts of rules_go in
internal/gazelle_binary.bzl on line 21 where it imports from
`go/private:rules/transitions.bzl` which is no longer the path to import
from once I created the BUILD file in `go/private/rules`.

As a temporary fix for this, I'm included a patch that changes that to
point to the new path. I will provide a follow up patch once rules_go
has been released to fix it properly in the gazelle repo and then remove
the patch from rules_go.

Fixed: bazelbuild#2619
Bug: bazelbuild/bazel-skylib#250
Bug: bazelbuild/bazel-gazelle#803
Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
achew22 added a commit to achew22/rules_go that referenced this issue Aug 27, 2020
@achew22 @aherrmann
Create bzl_library entries using gazelle-skylark
bb49af0 
There are a few minor manual modifications that needed to be performed.
For example, some `.bzl` files depend on `.bzl` files that are generated
outside of this repo and do not presently exist. `@bazel_tools` is a
great example of this.

Additionally this effort has revealed that bazel gazelle has an explicit
dependency on the private parts of rules_go in
internal/gazelle_binary.bzl on line 21 where it imports from
`go/private:rules/transitions.bzl` which is no longer the path to import
from once I created the BUILD file in `go/private/rules`.

As a temporary fix for this, I'm included a patch that changes that to
point to the new path. I will provide a follow up patch once rules_go
has been released to fix it properly in the gazelle repo and then remove
the patch from rules_go.

Fixed: bazelbuild#2619
Bug: bazelbuild/bazel-skylib#250
Bug: bazelbuild/bazel-gazelle#803
Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
@hugelgupf hugelgupf mentioned this issue Sep 18, 2020
Closed
achew22 added a commit to achew22/rules_go that referenced this issue Sep 22, 2020
@achew22 @aherrmann
Create bzl_library entries using gazelle-skylark
4b4348d 
There are a few minor manual modifications that needed to be performed.
For example, some `.bzl` files depend on `.bzl` files that are generated
outside of this repo and do not presently exist. `@bazel_tools` is a
great example of this.

Additionally this effort has revealed that bazel gazelle has an explicit
dependency on the private parts of rules_go in
internal/gazelle_binary.bzl on line 21 where it imports from
`go/private:rules/transitions.bzl` which is no longer the path to import
from once I created the BUILD file in `go/private/rules`.

As a temporary fix for this, I'm included a patch that changes that to
point to the new path. I will provide a follow up patch once rules_go
has been released to fix it properly in the gazelle repo and then remove
the patch from rules_go.

Fixed: bazelbuild#2619
Bug: bazelbuild/bazel-skylib#250
Bug: bazelbuild/bazel-gazelle#803
Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
achew22 added a commit to achew22/rules_go that referenced this issue Oct 22, 2020
@achew22 @aherrmann
Create bzl_library entries using gazelle-skylark
7621757 
There are a few minor manual modifications that needed to be performed.
For example, some `.bzl` files depend on `.bzl` files that are generated
outside of this repo and do not presently exist. `@bazel_tools` is a
great example of this.

Additionally this effort has revealed that bazel gazelle has an explicit
dependency on the private parts of rules_go in
internal/gazelle_binary.bzl on line 21 where it imports from
`go/private:rules/transitions.bzl` which is no longer the path to import
from once I created the BUILD file in `go/private/rules`.

As a temporary fix for this, I'm included a patch that changes that to
point to the new path. I will provide a follow up patch once rules_go
has been released to fix it properly in the gazelle repo and then remove
the patch from rules_go.

Fixed: bazelbuild#2619
Bug: bazelbuild/bazel-skylib#250
Bug: bazelbuild/bazel-gazelle#803
Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
jayconrod pushed a commit that referenced this issue Oct 23, 2020
@achew22
Create bzl_library entries using gazelle-skylark (#2621)
2bada59 
There are a few minor manual modifications that needed to be performed.
For example, some .bzl files depend on .bzl files that are generated
outside of this repo and do not presently exist. @bazel_tools is a
great example of this.

Additionally this effort has revealed that bazel gazelle has an explicit
dependency on the private parts of rules_go in
internal/gazelle_binary.bzl on line 21 where it imports from
go/private:rules/transitions.bzl which is no longer the path to import
from once I created the BUILD file in go/private/rules.

As a temporary fix for this, I'm included a patch that changes that to
point to the new path. I will provide a follow up patch once rules_go
has been released to fix it properly in the gazelle repo and then remove
the patch from rules_go.

Fixed: #2619
Bug: bazelbuild/bazel-skylib#250
Bug: bazelbuild/bazel-gazelle#803
@nlewo nlewo mentioned this issue Nov 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-health enhancement
Projects
None yet
Milestone
No milestone
2 participants
@jayconrod @aherrmann