Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Add new darwin CC toolchain for tests (#3460)" #3502

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Mar 29, 2023

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

This relands cd98170, which was reverted by commit 4660427.

The Xcode toolchain is now only enabled in tests.

Which issues(s) does this PR fix?

Fixes #3460

This relands cd98170, which was
reverted by commit 4660427.

The Xcode toolchain is now only enabled in tests.
@fmeum fmeum requested a review from linzhp March 29, 2023 08:23
@fmeum
Copy link
Collaborator Author

fmeum commented Mar 29, 2023

@keith Could you take a look?

Copy link
Contributor

@linzhp linzhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fmeum fmeum merged commit b39f91d into bazelbuild:master Mar 29, 2023
1 check passed
@fmeum fmeum deleted the reland-xcode branch April 1, 2023 09:50
linzhp pushed a commit that referenced this pull request Apr 20, 2023
This relands cd98170, which was
reverted by commit 4660427.

The Xcode toolchain is now only enabled in tests.
tingilee pushed a commit to tingilee/rules_go that referenced this pull request Jul 19, 2023
…elbuild#3502)

This relands cd98170, which was
reverted by commit 4660427.

The Xcode toolchain is now only enabled in tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants