bzlmod: Fix repo name used by gopackagesdriver #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of hard-coding `@io_bazel_rules_go` repo name.
This ensures that we always specify the correct repo name when invoking the aspect, even with Bzlmod (where users usually refer to rules_go as `@rules_go`, not `@io_bazel_rules_go`, but could choose any apparent repository name for it).
|
@tyler-french Could you review and check that this works at Uber (ideally with and without Bzlmod)? @bricedp Could you check that this works for you even without the environment variable set? |
|
Thanks @fmeum! Confirming that this works without the |
tyler-french
approved these changes
Apr 3, 2023
linzhp
pushed a commit
that referenced
this pull request
Apr 20, 2023
* Reference `rulesGoRepositoryName` (sourced from environment variable) instead of hard-coding `@io_bazel_rules_go` repo name. * gopackagesdriver: Inject rules_go repo name via x_defs This ensures that we always specify the correct repo name when invoking the aspect, even with Bzlmod (where users usually refer to rules_go as `@rules_go`, not `@io_bazel_rules_go`, but could choose any apparent repository name for it). --------- Co-authored-by: Brice <33697112+bricedp@users.noreply.github.com>
tingilee
pushed a commit
to tingilee/rules_go
that referenced
this pull request
Jul 19, 2023
* Reference `rulesGoRepositoryName` (sourced from environment variable) instead of hard-coding `@io_bazel_rules_go` repo name. * gopackagesdriver: Inject rules_go repo name via x_defs This ensures that we always specify the correct repo name when invoking the aspect, even with Bzlmod (where users usually refer to rules_go as `@rules_go`, not `@io_bazel_rules_go`, but could choose any apparent repository name for it). --------- Co-authored-by: Brice <33697112+bricedp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Ensure that we always specify the correct repo name when invoking the aspect by injecting it via
x_defs. This works even with Bzlmod (where users usually refer to rules_go as@rules_go, not@io_bazel_rules_go, but could choose any apparent repository name for it).Also replace one instance of a hardcoded repo name (thanks @bricedp).
Which issues(s) does this PR fix?
Fixes #3515
Other notes for review