Drop coverage linker flags from stdlib build #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stacked on #3521 |
fmeum
force-pushed
the
3472-coverage-stdlib
branch
from
1651196
to
faf34fd
Compare
achew22
approved these changes
Apr 6, 2023
This was referenced Apr 6, 2023
tyler-french
approved these changes
Apr 7, 2023
We never compile CGo with coverage instrumentation and the stdlib contains no user-provided C/C++ code, so linking coverage runtimes is never needed.
fmeum
force-pushed
the
3472-coverage-stdlib
branch
from
c8e72eb
to
cb24a37
Compare
linzhp
pushed a commit
that referenced
this pull request
Apr 20, 2023
We never compile CGo with coverage instrumentation and the stdlib contains no user-provided C/C++ code, so linking coverage runtimes is never needed.
tingilee
pushed a commit
to tingilee/rules_go
that referenced
this pull request
Jul 19, 2023
We never compile CGo with coverage instrumentation and the stdlib contains no user-provided C/C++ code, so linking coverage runtimes is never needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
We never compile CGo with coverage instrumentation and the stdlib contains no user-provided C/C++ code, so linking coverage runtimes is never needed.
Which issues(s) does this PR fix?
Work towards #3472
(fixing the issue requires a change to Bazel)
Other notes for review