[proto] Allow multiple outputs from a proto compiler #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tingilee
force-pushed
the
multi-suffix-compiler
branch
from
7b9eade
to
23c280d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR allows a proto compiler to output to multiple files. For example, in the test, the protoc compilation of the enum.proto will output to enum.pb.go and enum_dbenum.pb.go.
This PR adds a new field
suffixeswhich takes precedent oversuffixif set.suffix's behavior remains the same for backwards compatibility for code that already uses this field. However, long term,suffixcan be replaced bysuffixes.Which issues(s) does this PR fix?
Fixes #3630
Other notes for review