Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzlmod: Add missing experiments argument (#3443) #3663

Merged
merged 1 commit into from
Aug 19, 2023
Merged

bzlmod: Add missing experiments argument (#3443) #3663

merged 1 commit into from
Aug 19, 2023

Conversation

lbcjbb
Copy link
Contributor

@lbcjbb lbcjbb commented Aug 16, 2023

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Add the experiments argument of the go_sdk.download and go_sdk.host extensions.
This value will be given respectively to the go_download_sdk_rule and go_host_sdk_rule repository rule.

Which issues(s) does this PR fix?

Fixes #3443

Copy link
Collaborator

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

go/private/extensions.bzl Show resolved Hide resolved
@fmeum fmeum enabled auto-merge (squash) August 19, 2023 11:40
@fmeum
Copy link
Collaborator

fmeum commented Aug 19, 2023

@lbcjbb I don't have permission to push to your branch. Could you change that or rebase onto master yourself?

auto-merge was automatically disabled August 19, 2023 12:45

Head branch was pushed to by a user without write access

@lbcjbb
Copy link
Contributor Author

lbcjbb commented Aug 19, 2023

Yes, of course. Done !

@fmeum fmeum merged commit f64211a into bazelbuild:master Aug 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants