JDK warning about use of noverify option

[peakschris]

Coursier/rules_jvm_external are emitting warnings from the JVM about use of the -noverify option:

external/bazel_tools/jdk/bin/java -noverify -jar external/rules_jvm_external~~maven~unpinned_maven2/coursier --help
OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.

Can this be removed from here?

rules_jvm_external/private/rules/coursier.bzl

Line 271 in 0dfbe26

cmd = [java_path, "-noverify", "-jar"] + coursier_opts + _get_java_proxy_args(repository_ctx) + [jar_path]

Thanks!

[cheister]

There are two things to check:

• We still support Java 11 where "-noverify" is a valid option
• The comment above the line you listed has the comment

# The -noverify option seems to be required after the proguarding step
# of the main JAR of coursier.

so we would need to check that that is no longer needed for proguard

[shs96c]

We still support Java 11, and will for some time, so the real question is whether we still need this after recent coursier updates