Update Android-related tests to use Android Platforms flags #978
Comments
|
/cc @shs96c |
jin
pushed a commit
that referenced
this issue
Oct 16, 2023
Also disable Android platforms, see #978.
|
Fixed in #979 |
|
Reopening to track re-enablement of these tests. |
jin
added a commit
to shs96c/rules_jvm_external
that referenced
this issue
Nov 22, 2023
This adds the android_ndk and sets the appropriate default ndk specific flags in preparation for --android_platforms and toolchain resolution enablement. bazelbuild#978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A few test targets in this project are using either
android_binaryoraar_importtargets, and so need to be updated to work with Android platforms (bazelbuild/bazel#16285).Test
//tests/unit/aar_import/...is relatively easy: we need to define aplatformwith the android OS constraint and use that with the--platformsflag (because these are not part of an actualandroid_binary, we cannot use--android_platforms.Test
//tests/integration/override_targets/...is harder: when I did the above (using--android_platformsbecause this is anandroid_binary), I got very confusing errors due to theoverride_targetsfeature that is being tested. It looked from the errors as if the//tests/integration/override_targets:sceneform_renderingtarget is being configured both as a dependency of:app(which is correct), and in the top-level configuration (which is wrong, and causes build errors because the target platform is wrong).I don't understand the override targets feature but this feels like a bug to me.
For now I am sending a PR to disable Android platforms for these tests, but this should be addressed.
The text was updated successfully, but these errors were encountered: