Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_repin_required() missing [...] repository_ctx as of 687dc35 #981

Open
rdesgroppes opened this issue Oct 18, 2023 · 1 comment
Open

is_repin_required() missing [...] repository_ctx as of 687dc35 #981

rdesgroppes opened this issue Oct 18, 2023 · 1 comment

Comments

@rdesgroppes
Copy link
Contributor

rdesgroppes commented Oct 18, 2023

I just gave a try with current master branch (as of commit 687dc35) and faced:

$ REPIN=1 bazel run @unpinned_maven//:pin
INFO: Repository maven instantiated at:
  /path/to/WORKSPACE:138:11: in <toplevel>
  /path/to/maven/init.bzl:19:18: in init
  /path/to/external/rules_jvm_external/private/rules/maven_install.bzl:136:30: in maven_install
Repository rule pinned_coursier_fetch defined at:
  /path/to/external/rules_jvm_external/coursier.bzl:1236:40: in <toplevel>
ERROR: An error occurred during the fetch of repository 'maven':
   Traceback (most recent call last):
	File "/path/to/external/rules_jvm_external/coursier.bzl", line 465, column 39, in _pinned_coursier_fetch_impl
		if _fail_if_repin_required(repository_ctx):
	File "/path/to/external/rules_jvm_external/coursier.bzl", line 371, column 29, in _fail_if_repin_required
		return is_repin_required()
	File "/path/to/external/rules_jvm_external/coursier.bzl", line 363, column 5, in is_repin_required
		def is_repin_required(repository_ctx):
Error: is_repin_required() missing 1 required positional argument: repository_ctx
ERROR: /path/to/WORKSPACE:138:11: fetching pinned_coursier_fetch rule //external:maven: Traceback (most recent call last):
	File "/path/to/external/rules_jvm_external/coursier.bzl", line 465, column 39, in _pinned_coursier_fetch_impl
		if _fail_if_repin_required(repository_ctx):
	File "/path/to/external/rules_jvm_external/coursier.bzl", line 371, column 29, in _fail_if_repin_required
		return is_repin_required()
	File "/path/to/external/rules_jvm_external/coursier.bzl", line 363, column 5, in is_repin_required
		def is_repin_required(repository_ctx):
Error: is_repin_required() missing 1 required positional argument: repository_ctx
ERROR: Error computing the main repository mapping: no such package '@maven//': is_repin_required() missing 1 required positional argument: repository_ctx

I didn't check what changed yet, but wanted to share this issue prior to next release.

@rdesgroppes rdesgroppes changed the title is_repin_required() missing 1 required positional argument: repository_ctx as of commit 687dc35 is_repin_required() missing [...]: repository_ctx as of commit 687dc35 Oct 18, 2023
@rdesgroppes rdesgroppes changed the title is_repin_required() missing [...]: repository_ctx as of commit 687dc35 is_repin_required() missing [...] repository_ctx as of 687dc35 Oct 18, 2023
@rdesgroppes
Copy link
Contributor Author

Might be related to #975, @shs96c?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant