Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for passing ksp options #1036

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for passing ksp options #1036

wants to merge 2 commits into from

Conversation

idanakav
Copy link

Resolves #1035

Sanity tested with:

cd examples/ksp ; bazel aquery 'mnemonic(KotlinKsp, //:coffee_lib)' | grep ksp_opts -A 2

    --ksp_opts \
    'arg1=value1' \
    'arg2=value2' \

@idanakav
Add support for passing ksp options
742038e 
This commit adds the support to pass options to KSP processors, currently it the support is added on a target level only.
Eventually the options are passed through the kotlinc:
`-P google.devtools.ksp.symbol-processing:apoption=key=value`
@restingbull
Copy link
Collaborator

Does KSP fail if flags for absent plugins are passed?

@idanakav
Copy link
Author

Does KSP fail if flags for absent plugins are passed?

No, those are generic KSP options that are going to be forwarded to any KSP processor.
In other words, any KSP processor listed in the plugins will receive the same options.

@restingbull
Copy link
Collaborator

Does KSP fail if flags for absent plugins are passed?

No, those are generic KSP options that are going to be forwarded to any KSP processor. In other words, any KSP processor listed in the plugins will receive the same options.

Shoot. Going to need to track the plugin that needs the arguments.

@idanakav idanakav mentioned this pull request Feb 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

@cgruber cgruber Awaiting requested review from cgruber cgruber is a code owner

@restingbull restingbull Awaiting requested review from restingbull restingbull is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for passing options to KSP processors
2 participants
@idanakav @restingbull