New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'kt_abi_plugin_incompatible' should be respected even if 'experimental_use_abi_jars' is False #732

Open

oliviernotteghem opened this issue May 4, 2022 · 1 comment · May be fixed by #733

Contributor

oliviernotteghem commented May 4, 2022

In kotlin/internal/jvm/compile.bzl :

   if not "kt_abi_plugin_incompatible" in ctx.attr.tags and toolchains.kt.experimental_use_abi_jars == True:

We should probably do a larger cleanup, and remove all ref to experimental_use_abi_jars toolchain attribute

The text was updated successfully, but these errors were encountered:

oliviernotteghem linked a pull request

that will close this issue

'experimental_use_abi_jars' toolchain attribute cleanup #733

Open

Collaborator

restingbull commented May 6, 2022

experimental_use_abi_jars should remain false til 1.7 release. This is due to 1.6.20 being the first version that abi generation is 99% correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment