Skip to content

Commit

Permalink
fix(builtin): convert pkg_web to use cjs instead of js (#3500)
Browse files Browse the repository at this point in the history
  • Loading branch information
KrauseStefan committed Feb 3, 2023
1 parent 4b8bcf2 commit d36a73a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions internal/pkg_web/BUILD.bazel
Expand Up @@ -18,22 +18,22 @@ bzl_library(
nodejs_binary(
name = "assembler",
data = [
"assembler.js",
"assembler.cjs",
"//third_party/github.com/gjtorikian/isBinaryFile",
],
entry_point = ":assembler.js",
entry_point = ":assembler.cjs",
# TODO: figure out why isbinaryfile isn't resolved properly
templated_args = ["--bazel_patch_module_resolver"],
)

# BEGIN-INTERNAL
jasmine_node_test(
name = "assembler_test",
srcs = ["assembler_spec.js"],
srcs = ["assembler_spec.cjs"],
# TODO: figure out why isbinaryfile isn't resolved properly
templated_args = ["--bazel_patch_module_resolver"],
deps = [
"assembler.js",
"assembler.cjs",
"//third_party/github.com/gjtorikian/isBinaryFile",
],
)
Expand All @@ -43,6 +43,6 @@ filegroup(
name = "package_contents",
srcs = glob(
["*"],
exclude = ["*_spec.js"],
exclude = ["*_spec.cjs"],
),
)
File renamed without changes.
@@ -1,4 +1,4 @@
const assembler = require('./assembler');
const assembler = require('./assembler.cjs');
const path = require('path');
const fs = require('fs');

Expand Down

0 comments on commit d36a73a

Please sign in to comment.