feat(builtin): document how nodejs_binary#entry_point can use a direc… #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
commented
Apr 20, 2021
alexeagle
force-pushed
the
directory_entry_Point
branch
5 times, most recently
from
7adbb09
to
5b4111a
Compare
alexeagle
force-pushed
the
directory_entry_Point
branch
4 times, most recently
from
748db0e
to
1199cf1
Compare
alexeagle
force-pushed
the
directory_entry_Point
branch
from
1199cf1
to
67e8a03
Compare
alexeagle
force-pushed
the
directory_entry_Point
branch
from
4acb2ce
to
946b5c2
Compare
gregmagolan
approved these changes
May 25, 2021
alexeagle
force-pushed
the
directory_entry_Point
branch
from
946b5c2
to
16c749f
Compare
alexeagle
added a commit
that referenced
this pull request
May 26, 2021
#2579) * feat(builtin): document how nodejs_binary#entry_point can use a directory * refactor: rename to directory_entry_point per discussion * refactor: make the feature more general, suitable to upstream to bazel-skylib
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this pull request
Jan 13, 2022
bazelbuild#2579) * feat(builtin): document how nodejs_binary#entry_point can use a directory * refactor: rename to directory_entry_point per discussion * refactor: make the feature more general, suitable to upstream to bazel-skylib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tory