New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future plans of the concatjs devserver #2904
Comments
answers at a couple different levels:
|
I'm going to need some help to get this over the finish line. Either someone with time to finish it or a corporate user to fund the work. #2914 is WIP that would publish concatjs binaries on our releases and consume them as a toolchain then I think we need to upgrade rules_go, as the darwin_arm64 binary is very small so I suspect non-functional. #2905 is a start on that, however there was a breaking change to the Runfiles library a long time ago which we never accounted for, and is patched out. We basically got stuck on a fork. So I think we'll need to vendor in some of the code or refactor the devserver. |
Agreed 👍 I've replied on the toolchain start PR you created.
I'd argue that a devserver provided here would make sense because setting up devservers for Bazel w/ NodeJS requires logic for runfile resolution, so having one here seems useful. Surely this could be maintained by a third party but worth considering a simple JS based one. I don't feel strongly though. |
Hey team,
this is more of a question than an issue, but I wanted to check on the maintenance of the
concatjs
devserver thatis shipped as part of
@bazel/concatjs
.Previously, when the devserver still was part of
rules_typescript
, it was extremely difficult to land changes (like the windows support in the past) because the devserver implementation was synced into g3 and the team was hesitant to make any changes.Given that the TypeScript rules are now vendored, I wonder how/if the devserver is considered being maintained by
rules_nodejs
, especially since support for new platforms has been added in the past torules_nodejs
, but corresponding devserver binaries for these platforms have not been shipped. i.e. darwin arm64 for M1, linux_s390x, powerpc etc.rules_nodejs/packages/concatjs/devserver/BUILD.bazel
Lines 58 to 78 in 9b454e3
The filegroups have been defined for these platforms supported in
rules_nodejs
, but the actual binaries for example are not built in the vendoredrules_typescript
repository.. so there is actually no support for the concatjs devserver.It's worth asking the question: is it worth continuing to maintain the Go-based concatjs devserver, or would a more JS-based devserver be suitable (like we have built in the angular/components repo)? Such devservers could use e.g.
browser-sync
under the hood and allow for a lot of additional benefits.The text was updated successfully, but these errors were encountered: