Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename generated repo nodejs_host to nodejs #3375

Closed
alexeagle opened this issue Mar 26, 2022 · 3 comments · Fixed by #3610
Closed

Rename generated repo nodejs_host to nodejs #3375

alexeagle opened this issue Mar 26, 2022 · 3 comments · Fixed by #3610
Labels
Can Close? We will close this in 30 days if there is no further activity
Milestone
6.0

Comments

@alexeagle
Copy link
Collaborator

Same reasoning as bazelbuild/rules_python#656 where we changed rules_python.

/cc @UebelAndre
@alexeagle alexeagle added this to the 6.0 milestone Mar 26, 2022
@walkingeyerobot walkingeyerobot mentioned this issue Apr 4, 2022
Closed
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Sep 26, 2022
@alexeagle
Copy link
Collaborator Author

Still a good idea

@github-actions
Copy link

This issue was automatically closed because it went 30 days without any activity since it was labeled "Can Close?"

@alexeagle alexeagle reopened this Dec 12, 2022
alexeagle added a commit that referenced this issue Dec 12, 2022
@alexeagle
feat: provide @nodejs repository
7fb04c0 
Generally it's a bad practice that the user calls a repository rule (nodejs_register_toolchains) with a name, and this doesn't result in a repository with that name.

Leave the old _host variant around to make this a non-breaking change.

We did the same fix in python: bazelbuild/rules_python#656

Fixes #3375
@alexeagle alexeagle mentioned this issue Dec 12, 2022
Merged
alexeagle added a commit that referenced this issue Dec 12, 2022
@alexeagle
feat: provide @nodejs repository
2a75694 
Generally it's a bad practice that the user calls a repository rule (nodejs_register_toolchains) with a name, and this doesn't result in a repository with that name.

Leave the old _host variant around to make this a non-breaking change.

We did the same fix in python: bazelbuild/rules_python#656

Fixes #3375
alexeagle added a commit that referenced this issue Dec 12, 2022
@alexeagle
feat: provide @nodejs repository
a5755eb 
Generally it's a bad practice that the user calls a repository rule (nodejs_register_toolchains) with a name, and this doesn't result in a repository with that name.

Leave the old _host variant around to make this a non-breaking change.

We did the same fix in python: bazelbuild/rules_python#656

Fixes #3375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

feat: provide @nodejs repository bazelbuild/rules_nodejs
1 participant
@alexeagle