fix(builtin): convert pkg_web to use cjs instead of js

[KrauseStefan]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature (please, look at the "Scope of the project" section in the README.md file)
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Currently the pkg_web rule fails if the package.json type field is set to module in contrast to using the default common js modules.

Issue Number: N/A

What is the new behavior?

The build now works in either situation by fixing the files to be common js no matter the configuration in package.json

Does this PR introduce a breaking change?

• Yes
• No

Other information

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[KrauseStefan]

I am missing tests for this, and I am very much in doubt how I would go about doing that.
Any advice would be great :)

[github-actions]

This Pull Request has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

[KrauseStefan]

Any chance this can be rewied and eventually approved?

[gregmagolan]

Any chance this can be rewied and eventually approved?

Looks simple enough. I'll merge it in.

rules_nodejs is unmaintained at this point (since Q4 last year) and no new maintainers have stepped up. You should consider migrating to rules_js. Check out the migration guide. You can also get community support for rules_js on the #javascript channel on Bazel slack.

[KrauseStefan]

Thank you!
I have been looking a lot at rules_js and I do see great merits primarily in relation to package management. However I think it is best to wait with migration till angular/components migrate if they do.
Although I am puzzled why they haven't migrated or taken over maintenance yet...

[gregmagolan]

The Angular team is currently looking into migrating their OSS build to rules_js as well tho they haven't pulled the trigger yet on starting it. We'd need an answer to their ng_module but I believe that we can take the same worker approach we took in ts_project (in rules_js) to make a new ng_project rule that would have the same performance that ng_module does.

[gregmagolan]

You can already use ts_project with ngc without worker mode. Example found here, https://github.com/aspect-build/bazel-examples/tree/main/angular