Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_config_setting_private_default_visibility will break rules_nodejs in Bazel 7.0 #3603

Closed
keertk opened this issue Nov 23, 2022 · 2 comments
Closed

Flag --incompatible_config_setting_private_default_visibility will break rules_nodejs in Bazel 7.0 #3603

keertk opened this issue Nov 23, 2022 · 2 comments
Labels
Can Close? We will close this in 30 days if there is no further activity

Comments

@keertk
Copy link
Member

keertk commented Nov 23, 2022 •
edited

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_nodejs. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.
@keertk keertk mentioned this issue Nov 23, 2022
Open
@keertk keertk changed the title Flag --incompatible_config_setting_private_default_visibility will break rules_nodejs in a future Bazel release Flag --incompatible_config_setting_private_default_visibility will break rules_nodejs in Bazel 7.0 Nov 29, 2022
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This issue has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Jun 1, 2023
@sgowroji
Copy link
Member

sgowroji commented Jun 1, 2023

We are closing this issue as we can see no errors in the CI https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1536#0188747c-5ad8-4e0d-a2c9-cc845ff4b058

@keertk keertk closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgowroji @keertk