Add "npx" target to node repo #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjh
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
|
@matthewjh sorry this got stuck for so long - the test failures look legitimate, could you take a look? |
|
This Pull Request has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs! |
github-actions
bot
added
the
Can Close?
alexeagle
approved these changes
Aug 11, 2023
alexeagle
force-pushed
the
npx-fix
branch
2 times, most recently
from
c56dab4
to
03b1e42
Compare
|
I rebased and spent an hour debugging on Windows... :/ Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I want my developers to execute common node commands through
bazel run @nodejs//:xxx, so these use the node binary that bazel manages. Anything else can result in creeping inconsistencies due to different pathways using different node versions.Npm is covered by
bazel run @nodejs//:npm, but there is no equivalent for the npx binary.There is
npx_bin, but this is a direct invocation of the npx-cli.js script and uses /usr/local/bin/node rather than the Bazel-managed node binary. This is misleading as the expectation would be that it's going to use the latter.Issue Number: N/A
What is the new behavior?
This PR adds an npx target to the node repo which can be invoked with Bazel run, e.g.
bazel run @nodejs//:npx. This target works just as thenpmtarget does and calls into the .js script via the Bazel-managed node executable.Does this PR introduce a breaking change?
Other information
Quesions:
Can I remove the npx_bin target?