Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set --fatal_warnings? #96

Open
Kernald opened this issue Aug 24, 2021 · 3 comments
Open

How to set --fatal_warnings? #96

Kernald opened this issue Aug 24, 2021 · 3 comments
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) question Further information is requested

Comments

@Kernald
Copy link

Kernald commented Aug 24, 2021

Is there a way to enforce that every proto_library target are compiled with --fatal_warnings?

For reference, this flag was added here, and causes the compilation to fail if a warning is raised, like -Werror with GCC.

@comius
Copy link
Collaborator

comius commented Feb 8, 2022

Try using --protocopt=--fatal_warning.

@comius comius added the P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) label Feb 8, 2022
@Kernald
Copy link
Author

Kernald commented Feb 8, 2022

--protocopt=--fatal_warnings indeed seems to work. I'm happy to either close this or leave it open to have a way to set this directly in the toolchain configuration in Bazel - not sure what's the most common way to do this kind of things.

@Yannic
Copy link
Collaborator

Yannic commented Feb 8, 2022

We should have a way to specify protoc-opts in the (not-yet-existing) proto_toolchain in addition to the command-line.

@Yannic Yannic added the question Further information is requested label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants