Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_config_setting_private_default_visibility will break rules_python in Bazel 7.0 #1237

Closed
sgowroji opened this issue May 19, 2023 · 8 comments
Labels
Can Close? Will close in 30 days if there is no new activity help wanted

Comments

@sgowroji
Copy link
Member

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_go. Please migrate to fix this and unblock the flip of this flag.

---> Note that this was not an issue until build #1349 and has been failing from #1351 onwards.

The flag is documented here: bazelbuild/bazel#12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

@sgowroji
Copy link
Member Author

Hi @chrislovecnm, Could you please look in to this issue.Thanks!

@chrislovecnm
Copy link
Collaborator

#1283 is the only place that I see problems with that flag. Please let me know if that upgrade fixes the problem.

@chrislovecnm
Copy link
Collaborator

@sgowroji can we close this issue?

@chrislovecnm
Copy link
Collaborator

I'm closing; I believe this is fixed.

@sgowroji
Copy link
Member Author

sgowroji commented Aug 8, 2023

But we are still seeing few errors https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1608#0189d2b2-f127-4378-a10b-6a39bd60911e

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/6fa682abed4ae69553486804e0da2756/external/io_bazel_rules_go/BUILD.bazel:106:10: in go_config rule @io_bazel_rules_go//:go_config: target '@io_bazel_rules_go//go/private:stamp' is not visible from target '@io_bazel_rules_go//:go_config'. Check the visibility declaration of the former target if you think the dependency is legitimate
(01:27:49) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/6fa682abed4ae69553486804e0da2756/external/io_bazel_rules_go/BUILD.bazel:106:10: Analysis of target '@io_bazel_rules_go//:go_config' failed
(01:27:49) ERROR: Analysis of target '//python:python_test' failed; build aborted: Analysis failed

@chrislovecnm
Copy link
Collaborator

This is in rules_go let me make sure that we have the latest version

@chrislovecnm chrislovecnm reopened this Aug 8, 2023
Copy link

github-actions bot commented Feb 4, 2024

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Feb 4, 2024
Copy link

github-actions bot commented Mar 6, 2024

This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

@github-actions github-actions bot closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days if there is no new activity help wanted
Projects
None yet
Development

No branches or pull requests

2 participants