Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates_vendor doesn't support build metadata in version strings #2620

Open
granaghan opened this issue Apr 18, 2024 · 0 comments
Open

crates_vendor doesn't support build metadata in version strings #2620

granaghan opened this issue Apr 18, 2024 · 0 comments

Comments

@granaghan
Copy link
Contributor

In my Cargo.toml, I have:

proc-macro-hack = "0.5.20+deprecated"

crates_vendor downloads the crate into proc-macro-hack-0.5.20+deprecated, however the generated rules replace the "+" with a "-", causing errors.

alias(                                                                                                                                                                                                                                                                         
    name = "proc-macro-hack",                                                                                                                                                                                                                                                  
    actual = "//third_party/cargo/registry/bazel/no_std/vendor/proc-macro-hack-0.5.20-deprecated:proc_macro_hack",                                                                                                                                                             
    tags = ["manual"],                                                                                                                                                                                                                                                         
) 
@granaghan granaghan changed the title crates_vendor generates incorrect path for crates with "+" in the version crates_vendor doesn't support build metadata in version strings Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant