Added logging to crate_universe checksum validation #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
crate_universe_update
branch
from
be585d4
to
bc6b121
Compare
illicitonion
approved these changes
May 16, 2024
Merged
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rrbutani
pushed a commit
to bazel-contrib/toolchains_llvm
that referenced
this pull request
May 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rules_rust](https://togithub.com/bazelbuild/rules_rust) | http_archive | minor | `0.44.0` -> `0.45.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_rust (rules_rust)</summary> ### [`v0.45.0`](https://togithub.com/bazelbuild/rules_rust/releases/tag/0.45.0) [Compare Source](https://togithub.com/bazelbuild/rules_rust/compare/0.44.0...0.45.0) ### 0.45.0 ```python load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-0IoZbO7cp5obgv01ucsnAjrWdGpBasntBusUXtdj1aY=", urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.45.0/rules_rust-v0.45.0.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Fix cc_common_link when using sibling repository layout by [@​yuzhy8701](https://togithub.com/yuzhy8701) in [bazelbuild/rules_rust#2643 - Allow runfiles object to be an arbitrary expression. by [@​matts1](https://togithub.com/matts1) in [bazelbuild/rules_rust#2651 - Allow searching for the rlocation of a module. by [@​matts1](https://togithub.com/matts1) in [bazelbuild/rules_rust#2652 - Add support for generated sources to rust-analyzer. by [@​matts1](https://togithub.com/matts1) in [bazelbuild/rules_rust#2654 - Added logging to crate_universe checksum validation by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/rules_rust#2657 - Release 0.45.0 by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/rules_rust#2658 #### New Contributors - [@​yuzhy8701](https://togithub.com/yuzhy8701) made their first contribution in [bazelbuild/rules_rust#2643 **Full Changelog**: bazelbuild/rules_rust@0.44.0...0.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
UebelAndre
commented
May 16, 2024
There was a problem hiding this comment.
Crap!
This should be
if result.return_code:
@illicitonion would you be able to do me a huge favor and put up a fix for this and cut a new release? I won’t be available to author a change for some time and this is pretty breaking :(
illicitonion
added a commit
to illicitonion/rules_rust
that referenced
this pull request
May 16, 2024
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
CARGO_BAZEL_DEBUG=1is enabled, the following log lines will print when determining repins.