Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[swift_proto_library] Generated types are always public #961

Open
tylervick opened this issue Jan 3, 2023 · 1 comment · May be fixed by #962
Open

[swift_proto_library] Generated types are always public #961

tylervick opened this issue Jan 3, 2023 · 1 comment · May be fixed by #962

Comments

@tylervick
Copy link

Currently the Visibility generation option is hardcoded to Public for all protobuf generation:

rules_swift/swift/internal/swift_protoc_gen_aspect.bzl

Line 185 in 7ea1970

protoc_args.add("--swift_opt=Visibility=Public")

Certain use cases require a non-public access level for generated objects. For example, when creating a library without exposing messages to the consumer.
@tylervick tylervick linked a pull request Jan 4, 2023 that will close this issue
Open
@thomasvl
Copy link
Member

thomasvl commented Jan 4, 2023

This is because each swift_proto_library ends up being a module. If it was anything other than public how would it be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add generate_internal_visibility_from_proto_files feature tylervick/rules_swift
2 participants
@tylervick @thomasvl