Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a release that includes support for keyword-only arguments #52

Open
alanfalloon opened this issue Apr 9, 2020 · 2 comments
Open

Comments

@alanfalloon
Copy link

alanfalloon commented Apr 9, 2020

Bazel 2.1 instroduced Starlark changes that allow keyword-only parameters.

For example:

def foo(arg1, arg2, *, kwonly1):
    pass

But running Stardoc 0.4.0 on .bzl files with that new syntax fails with:

Stardoc documentation generation failed: Starlark evaluation error
@alanfalloon
Copy link
Author

I didn't try a version from master, but a quick skim of the commits didn't show any obvious changes to Starlark evaluation.

@brandjon
Copy link
Member

It actually seems like a somewhat major issue to me that Stardoc would be incompatible with keyword-only arguments.

I was able to reproduce this issue with Stardoc 4.0, but it seems to be fixed at head. So I suppose the real issue is cutting a new release.

@brandjon brandjon changed the title Stardoc fails on keyword-only argument Cut a release that includes support for keyword-only arguments Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants