Include load in summaries
#216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
95-loads
branch
2 times, most recently
from
a107264
to
aed67db
Compare
|
Some tests are failing due to differing repository names. I can look into this when there is general consensus on the approach. I'm also happy to make this new behavior configurable in the template. |
tetromino
requested changes
May 20, 2024
tetromino
requested changes
May 20, 2024
There was a problem hiding this comment.
Instead of hard-coding maybeLoad(...) + summary(...) in java - expose the load string to templates, and format it in the template.
There was a problem hiding this comment.
I did that. I got rid of the aspect flag comment as it feels to niche.
Rules, providers, functions and aspects now have a small `load` statement in their summary. Aspects additionally include a copyable `--aspects` flag.
|
The WORKSPACE tests are failing since they use a different repo name for Stardoc, which now appears in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules, providers, functions and aspects now have a
loadstatement in their summary. Aspects additionally include a copyable--aspectsflag.Fixes #95