Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axe-linter configuration file #9846

Closed
wants to merge 3 commits into from
Closed

axe-linter configuration file #9846

wants to merge 3 commits into from

Conversation

DarioR01
Copy link
Contributor

@DarioR01 DarioR01 commented Feb 9, 2022 •
edited

Resolves #4583

Overall change:
Configure axe-linter to ignore certain files.

Code changes:

  • created yml configure file
  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project
  • (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • This PR requires manual testing

@DarioR01 DarioR01 added the a11y Accessibility-related task label Feb 9, 2022
@DarioR01 DarioR01 self-assigned this Feb 9, 2022
@DarioR01
Copy link
Contributor Author

It looks like the axe-linter does not have a way of ignoring these issues. I will close this PR as they don't cause any major disruption

@DarioR01 DarioR01 closed this Apr 13, 2022
@DarioR01 DarioR01 deleted the Disable_a11yLinter_in_tests branch April 13, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DarioR01 DarioR01

Labels
a11y Accessibility-related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Axe-Linter errors in useClickTrackerHandler test
2 participants
@DarioR01 @ryanmccombe