Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code that uses unstable nested components #10007

Open
2 tasks
DarioR01 opened this issue Apr 1, 2022 · 0 comments
Open
2 tasks

Refactor code that uses unstable nested components #10007

DarioR01 opened this issue Apr 1, 2022 · 0 comments
Labels
technical-work Technical debt, support work and building new technical tools and features

Comments

@DarioR01
Copy link
Contributor

DarioR01 commented Apr 1, 2022

Is your feature request related to a problem? Please describe.

no-unstable-nested-components is a new rule coming from eslint-config-airbnb to v19 that prevents the bad practice of creating a React component inside another React component.

Thanks to eslint-config-airbnb to v19 package major update we are now able to identify places in our code where we use this bad practice. We should refactor all places where we use unstable nested components before upgrading to this new major version.

Describe the solution you'd like

Fix all occurance of no-unstable-nested-component.
To visualise a list of components that have this issue:

  1. checkout into renovate/eslint-config-airbnb-19.x with git checkout renovate/eslint-config-airbnb-19.x
  2. run yarn && yarn test:lint
  3. Locate all files with no-unstable-nested-components error description on the output

Alternatively

  1. Go to https://github.com/bbc/simorgh/runs/5754191013?check_suite_focus=true
  2. Locate all files with no-unstable-nested-components error description

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Checklist

Additional context
Add any other context or screenshots about the feature request here.

@DarioR01 DarioR01 added the technical-work Technical debt, support work and building new technical tools and features label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Development

No branches or pull requests

1 participant