Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Styled Components V4 #709

Closed
bcmn opened this issue Sep 24, 2018 · 1 comment
Closed

Upgrade to Styled Components V4 #709

bcmn opened this issue Sep 24, 2018 · 1 comment
Labels
external blocked Blocked by an external dependency

Comments

@bcmn
Copy link
Contributor

bcmn commented Sep 24, 2018

There doesn't seem to be a set release date being discussed for V4 yet, as far as I found with a quick look.

Initial work for switching is on the styled-components-v4 branch.

At the moment there seems to only be one blocker when attempting to switch to the current beta:

  • Waiting on [jest-styled-components](https://github.com/styled-components/jest-styled-components) to support V4, see this issue
@bcmn bcmn added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Sep 24, 2018
@bcmn bcmn mentioned this issue Sep 24, 2018
Closed
2 tasks
@ChrisBAshton ChrisBAshton added external blocked Blocked by an external dependency and removed blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Nov 27, 2018
@dr3
Copy link
Contributor

dr3 commented Apr 9, 2019

Done https://github.com/bbc/simorgh/blob/latest/package.json#L125

@dr3 dr3 closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external blocked Blocked by an external dependency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChrisBAshton @dr3 @bcmn