Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test label for products created for temporary purpose (e.g. training) #2841

Closed
Iryna-Kaplun opened this issue May 16, 2024 · 2 comments
Closed
Assignees

Comments

@Iryna-Kaplun
Copy link
Collaborator

Iryna-Kaplun commented May 16, 2024

Cailey will provide the language for the checkbox.

Checkbox language:

Temporary product set: this product set will be automatically deleted after 30 days.

Let's maybe also have a pop-up when they submit that says:

You have selected a temporary product set. Please be aware that everything in the provisioned namespaces will be deleted after 30 days, including all data and deployments. Are you sure you want a temporary product set?

DoD:

  • add a temporary label to create product page to temporary created namespaces (e.g. training purpose, etc.)
  • add a flag to the DB schema
  • exclude products with this label from the analytics dashboard
  • create script to add filed isTest

Checkbox language:
Temporary product set: this product set will be automatically deleted after 30 days.
Let's maybe also have a pop-up when they submit that says:
You have selected a temporary product set. Please be aware that everything in the provisioned namespaces will be deleted after 30 days, including all data and deployments. Are you sure you want a temporary product set?

@Iryna-Kaplun Iryna-Kaplun changed the title Add Test label for products created for testing Add Test label for products created for temporary purpose (e.g. training) May 16, 2024
@junminahn
Copy link
Collaborator

  • add a checkbox
  • update the chart query to exclude them

@funtigr
Copy link
Collaborator

funtigr commented May 28, 2024

Now the checkbox is in place that allows to toggle on temporary status for the product.
It is available both on Create page and on Product page (so you can add this status after provisioning too).
image.png

After checking the checkbox the popup with confirmation text is displayed:
image.png

Marking existing product as Temporary creates a new Edit Request which is approved automatically.

@funtigr funtigr closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants