Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncovered branch #196

Open
concatime opened this issue Feb 4, 2020 · 5 comments
Open

Uncovered branch #196

concatime opened this issue Feb 4, 2020 · 5 comments
Labels
bug more-info-needed For issues that have not be described fully

Comments

@concatime
Copy link

node -v
# v13.7.0

I use the official binary form NodeJS.org on a 64bit GNU+Linux platform.

Hi. I’m trying to setup a template repo. using ESM. Almost everything works. When I run the coverage, I get:

---------------------|---------|----------|---------|---------|-------------------
File                 | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
---------------------|---------|----------|---------|---------|-------------------
All files            |     100 |    64.71 |     100 |     100 |                   
 entities.ts         |     100 |       60 |     100 |     100 | 35                
 inversify.config.ts |     100 |      100 |     100 |     100 |                   
 types.ts            |     100 |      100 |     100 |     100 |                   
---------------------|---------|----------|---------|---------|-------------------

My issue is that entities.ts#35 is merely export { Katana, Ninja, Shuriken };.
In inversify.config.ts, I import everything import { Katana, Ninja, Shuriken } from './entities';, so this line should be covered. Am I doing something wrong, or is it a bug in C8?

Thank you.

@concatime
Copy link
Author

@bcoe bcoe added the bug label Feb 4, 2020
@bcoe
Copy link
Owner

bcoe commented Mar 7, 2020

@concatime when I try to run your example repo I get this error:

internal/modules/run_main.js:54
    internalBinding('errors').triggerUncaughtException(
                              ^

TypeError [ERR_INVALID_RETURN_PROPERTY_VALUE]: Expected string to be returned for the "format" from the "loader getFormat" function but got type object.
    at Loader.getFormat (internal/modules/esm/loader.js:110:13)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Loader.getModuleJob (internal/modules/esm/loader.js:192:20)
    at async Loader.import (internal/modules/esm/loader.js:166:17) {
  code: 'ERR_INVALID_RETURN_PROPERTY_VALUE'
}
npm ERR! Test failed.  See above for more details.

Do you have a minimal reproduction I could use to try to hunt down the issue?

@bcoe bcoe added the more-info-needed For issues that have not be described fully label Mar 7, 2020
@concatime
Copy link
Author

concatime commented Mar 9, 2020

I have no issue running my template. Have you followed the readme file? Which node version do you have?
EDIT: My template works with node >= 13.2.0

@concatime
Copy link
Author

I have now the same issue as you. It happens with node >= 13.9.0

@concatime
Copy link
Author

I updated the repo, it should be solved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug more-info-needed For issues that have not be described fully
Projects
None yet
Development

No branches or pull requests

2 participants