Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with built project #1

Open
sjb933 opened this issue Nov 19, 2017 · 0 comments
Open

Error with built project #1

sjb933 opened this issue Nov 19, 2017 · 0 comments

Comments

@sjb933
Copy link

sjb933 commented Nov 19, 2017

Hello - thanks for putting this project together. I'm getting started with it now, and I'm building the project as-is. I've got the project successfully building, but when I run the compiled executable, I get the following message:

"Uncaught Exception: Error: Cannot find module 'electron-compile'". This should not be a runtime dependency, to my knowledge. I'm building this on Windows 10 x64.

Steps to reproduce:

  1. Fresh clone
  2. Give project description in package.json (required at time of build)
  3. yarn install
  4. yarn make
  5. run the compiled executable

image
@nigelgilbert nigelgilbert mentioned this issue Sep 13, 2018
Merged
bdero added a commit that referenced this issue Sep 14, 2018
@bdero
Merge pull request #2 from nigelgilbert/bugs/built-project-error
616b3ce 
@nigelgilbert You rock, thanks!

Just tested this on Windows and it does help with #1. It looks like this repo needs some love in general.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjb933