Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SentEmailViewer should work with with all adapters. #518

Open
seivan opened this issue Jan 27, 2020 · 2 comments
Open

SentEmailViewer should work with with all adapters. #518

seivan opened this issue Jan 27, 2020 · 2 comments
Labels
waiting-for-info Request for more information sent, awaiting reply

Comments

@seivan
Copy link

seivan commented Jan 27, 2020

It would be nice if SentEmailViewer still worked with other adapters, maybe LocalAdapter could be an add-on and not just the only one used.

The rational is that we're using SES Mailbox Simulator for non prod environments, and would love to be able to use it while still having access to the SentEmailViewer.

My suggestion is that LocalAdapter should not be a replacement for an actual adapter, but an addition.

Is this something that's acceptable? In which case I don't mind setting up a PR for it.

@germsvel
Copy link
Collaborator

Thanks for mentioning this @seivan . I'm not a 100% sure, but I think you could make this work already as is by using Bamboo.SentEmail? That's what the LocalAdapter uses, right?

So if you wrote your own adapter that uses SentEmail to store and fetch the emails, then you might be good to go? I know that's technically internal workings of LocalAdapter and SentEmailViewer and thus liable to change, so it might be good to make it official somehow. But for now, would that solve your problem?

@germsvel germsvel added the waiting-for-info Request for more information sent, awaiting reply label May 14, 2021
@seivan
Copy link
Author

seivan commented Oct 28, 2021

@germsvel Sorry for the delay.
But the documentation states To see emails you must use the Bamboo.LocalAdapter.
This seems a bit unnecessary, this should be configuration on Bamboo itself and not an adapter implementation.

So I am wondering if it's possible to add the option to enable Bamboo.SentEmail regardless of adapter usage?
If not, are you open to the idea? I would need some help with testing but I don't mind writing a PoC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-info Request for more information sent, awaiting reply
Projects
None yet
Development

No branches or pull requests

2 participants