Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iodata() usage #610

Open
fuelen opened this issue Jun 14, 2021 · 3 comments
Open

Allow iodata() usage #610

fuelen opened this issue Jun 14, 2021 · 3 comments
Labels
more-info Needs more information.

Comments

@fuelen
Copy link
Contributor

fuelen commented Jun 14, 2021

HTML and text bodies can be rendered as iodata. The idea is to encode iodata to string on an adapter level, or use iodata as is if possible. This approach in theory would improve performance for some adapters.

@germsvel
Copy link
Collaborator

Hi @fuelen thank you for opening this issue.

I understand that in theory allowing iodata would improve performance. But I'm wondering, are you experiencing performance issues with Bamboo right now?

If so, I'd love to get a better sense of where the bottleneck lies. If it turns out allowing for iodata usage fixes that bottleneck, then it might make sense to do this work. Otherwise, I don't know if this is worth pursuing right now.

@germsvel germsvel added the more-info Needs more information. label Jun 25, 2021
@fuelen
Copy link
Contributor Author

fuelen commented Jun 28, 2021

Hi @germsvel

No, I don't have performance issues for now. I've worked on custom templating engine and realized, that I've to convert iodata to string manually, because bamboo doesn't support iodata. I'd say it is more about design approaches overall.

@germsvel
Copy link
Collaborator

I've worked on custom templating engine and realized, that I've to convert iodata to string manually, because bamboo doesn't support iodata.

Ohhh, got it. Thanks for adding that clarity @fuelen. I don't have a good sense (off the top of my head) of how we would support that. But if there's a straightforward way, I'd be happy to review a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-info Needs more information.
Projects
None yet
Development

No branches or pull requests

2 participants