Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple values for same filter #235

Open
CostantiniMatteo opened this issue Sep 4, 2020 · 1 comment
Open

Multiple values for same filter #235

CostantiniMatteo opened this issue Sep 4, 2020 · 1 comment

Comments

@CostantiniMatteo
Copy link
Contributor

The jsonapi spec states that multiple filter values can be combined in a comma-separated list. For example:

GET /comments?filter[post]=1,2 HTTP/1.1

However, I noticed that the library returns a string "1,2" instead of splitting it and returning ["1", "2"].

Is this by design, and therefore such cases needs to be handled manually by splitting the string?
I would be happy to implement it, if the change is welcome.

Thank you!
@jherdman
Copy link
Contributor

jherdman commented Sep 4, 2020

Definitely a welcome change.

@CostantiniMatteo CostantiniMatteo mentioned this issue Sep 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jherdman @CostantiniMatteo