Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripe.Account.retrive/1 not working in OpenAPI build #777

Closed
marmor157 opened this issue Jan 11, 2023 · 5 comments · May be fixed by #786
Closed

Stripe.Account.retrive/1 not working in OpenAPI build #777

marmor157 opened this issue Jan 11, 2023 · 5 comments · May be fixed by #786
Labels
stale:discard

Comments

@marmor157
Copy link

I was testing out the new OpenAPI build and wanted to use Stripe.Account.retrieve passing an account id and it failed with the following error.

** (BadMapError) expected a map, got: "***"
    (stdlib 4.1.1) :maps.merge(%{}, "***")
    (stripity_stripe 2.17.3) lib/stripe/request.ex:98: Stripe.Request.put_params/2
    (stripity_stripe 2.17.3) lib/openapi/phases/compile.ex:199: Stripe.Account.retrieve/2
    iex:3: (file)

Code to reproduce:

Stripe.Account.retrieve("***")

Where "***" is a Stripe account id.

The test responsible for this is commented out

stripity-stripe/test/stripe/connect/account_test.exs

Line 10 in 0d9e435

# test "is retrievable using plural endpoint" do

@snewcomer
Copy link
Collaborator

@marmor157 Yep you are correct. We have to fix that. There are two ways to get it according to their api spec, but the first must be the only one that ends up in the codemod! I'll have to find some time to fix it 👍

Screen Shot 2023-01-14 at 2 32 34 PM

@nkezhaya
Copy link
Contributor

@snewcomer This is affecting some other endpoints as well, like Stripe.Card.retrieve/*.

@snewcomer
Copy link
Collaborator

@nkezhaya Thanks. Let me take a look this weekend 🙇‍♂️ and hopefully get this resolved.

@maartenvanvliet maartenvanvliet mentioned this issue Feb 17, 2023
Open
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This issue has been automatically marked as "stale:discard". If this issue still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment.

@github-actions
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still relevant, feel free to re-open the issue. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale:discard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for getting account by id maartenvanvliet/stripity_stripe
3 participants
@nkezhaya @snewcomer @marmor157