Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odd isInSubnet behavior #60

Open
asaf-romano opened this issue Dec 1, 2017 · 2 comments
Open

Odd isInSubnet behavior #60

asaf-romano opened this issue Dec 1, 2017 · 2 comments

Comments

@asaf-romano
Copy link 

> new Address4("10.2.30.1/16").isInSubnet(new Address4("10.2.30.2"))
false

Is that expected? it seems isInSubnet won't actually tell you whether or not some address is contained by a range of ips represented by a CIDR. Is there another method from that?
@asaf-romano
Copy link
Author

False alarm. Sorry! I just got the direction wrong (it's in fact address.isInSubnet(subnet)). The documentation is a little confusing regarding the expected relation.

@beaugunderson
Copy link
Owner

sorry for the poor docs! i'll leave this issue open until i have a chance to clarify them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beaugunderson @asaf-romano