Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing documentation seems inconsistent #70

Open
alexkokkinos opened this issue Jan 21, 2019 · 1 comment
Open

Timing documentation seems inconsistent #70

alexkokkinos opened this issue Jan 21, 2019 · 1 comment

Comments

@alexkokkinos
Copy link

It looks like the example documentation on how to use the timing functionality isn't consistent with the expected data type and unit of measure:

README.md:

$start = microtime(true);
$diff  = microtime(true) - $start;
$collector->timing('foo.bar', $diff);

In this example, $diff will be a float representing the time delta value in microseconds, while the interface expects an int representing milliseconds:

Collector.php:

    /**
     * Records a timing.
     *
     * @param string $variable
     * @param int    $time     The duration of the timing in milliseconds
     */
    public function timing($variable, $time);
@alexkokkinos
Copy link
Author

See #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant