Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Losing pending changes after closing the app #2201

Open
azmy60 opened this issue May 12, 2024 · 3 comments · May be fixed by #2209
Open

BUG: Losing pending changes after closing the app #2201

azmy60 opened this issue May 12, 2024 · 3 comments · May be fixed by #2209
Labels
accepted 👍 bug Something isn't working good first issue Good for newcomers

Comments

@azmy60
Copy link
Contributor

azmy60 commented May 12, 2024

To Reproduce
Steps to reproduce the behavior:

  1. Go to table view
  2. Edit some data
  3. exit the app
  4. BKS doesn't show a warning for losing changes
  5. After re-opening BKS, the changes in the table view is gone

Expected behavior
It should show a warning modal like when closing a tab.
@azmy60 azmy60 added bug Something isn't working good first issue Good for newcomers accepted 👍 labels May 12, 2024
@H0onnn
Copy link

H0onnn commented May 14, 2024

@azmy60 Hello ! Can I solve this problem ?

@azmy60
Copy link
Contributor Author

azmy60 commented May 14, 2024

Hey @H0onnn, sure! Feel free to submit a PR! :)

@H0onnn H0onnn linked a pull request May 17, 2024 that will close this issue
Open
@H0onnn
Copy link

H0onnn commented May 17, 2024

Hello, @azmy60 !

I just posted a PR for the issue. Please check ! #2209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted 👍 bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Add exit confirmation modal before quitting H0onnn/beekeeper-studio
2 participants
@azmy60 @H0onnn