Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Several more issues with focus (largely thanks to Tabulator / Codemirror) #2187

Closed
rathboma opened this issue May 7, 2024 · 1 comment · Fixed by #2203
Closed

BUG: Several more issues with focus (largely thanks to Tabulator / Codemirror) #2187

rathboma opened this issue May 7, 2024 · 1 comment · Fixed by #2203
Assignees
Labels
accepted 👍 bug Something isn't working

Comments

@rathboma
Copy link
Collaborator

rathboma commented May 7, 2024

Goal: Users should be able to navigate around the whole app with the keyboard, even if they can't do 'everything', they shouldn't have to click to perform primary actions.

If I click CMD-W to close a tab, I get the following prompt, and there's no way to tab through the options in the modal, nor does Enter work. This is because focus stays in the editor in the background.

image
FIX:
It should have one of the options selected by default. Probably 'cancel', it should let you tab between them. This used to be the case, this is a regression.

2. When you switch to a tab opened via "View Data" with the keyboard, focus goes elsewhere (even though the first cell looks selected!), so you can't use the keyboard to navigate the rows.

image

  • This is another weird tabulator focus bug

3. I can't figure out a way to switch which pane is selected using keyboard shortcuts.

image

  • This should be ctrl+tab maybe?
@rathboma rathboma added bug Something isn't working accepted 👍 labels May 7, 2024
@azmy60
Copy link
Contributor

azmy60 commented May 7, 2024

I've been wanting to call this out because I use keyboard almost every time. This will be so satisfying! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted 👍 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants