Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

you can mention non-existent users in chat, plus whispers # is not removed #2818

Open
nadirabbas opened this issue May 18, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nadirabbas
Copy link
Contributor

nadirabbas commented May 18, 2021

@HoloPanio after the integration of dolma I believe, we can mention nonexistent users in the chat. previously we used to cross-check for mentioned users in the room users list, if found. token = mention, otherwise token = text

image

you can also see another bug that was introduced, which is that when you whisper using #@username syntax, the # won't get removed from the message.

@nadirabbas nadirabbas added the bug Something isn't working label May 18, 2021
@nadirabbas nadirabbas changed the title you can mention non-existent users in chat you can mention non-existent users in chat, plus whispers # is not removed May 18, 2021
@ghost
Copy link

ghost commented May 21, 2021

This shouldn't be a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants