Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Set alert threshold per value for more fine-grained control #183

Open
jellespijker opened this issue Aug 12, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@jellespijker
Copy link

We have a workflow which analyzes the output of our product and and sometimes a lower values is better, while other times a higher value is better.
https://github.com/Ultimaker/CuraEngine/blob/33790412b61f33e4f4bfe1af2512f2f621e7aff5/.github/workflows/gcodeanalyzer.yml#L181

Allow for alert_threshold to be set per value will give a more fine-grained control

          {
            "name": "Quantity which should not increase",
            "value": 12503.752753577128,
            "unit": "s"
            "alert_treshold": ">110%"
          },
          {
            "name": "Quantity which should not decrease",
            "value": 182291,
            "unit": "-"
            "alert_threshold": "<90%"
          },
@ktrz
Copy link
Member

ktrz commented Apr 3, 2024

Hi @jellespijker

Thank you for filing an issue! Sorry for taking so long to get back to you on this.

I would love to consider this enhancement. Do you know how you would like to configure this behavior? One thing that I'm planning to do is to calculate the "bigger is better" boolean based on the unit. Does your workflow generate output with units that could be used to determine if the bigger or smaller value is better? If so then this could probably be the easiest fix for this

@ktrz ktrz added the enhancement New feature or request label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants