Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action continue after error in foo | tee output.txt #184

Open
LuckyTurtleDev opened this issue Aug 13, 2023 · 1 comment
Open

github action continue after error in foo | tee output.txt #184

LuckyTurtleDev opened this issue Aug 13, 2023 · 1 comment

Comments

@LuckyTurtleDev
Copy link

if you use run cargo +nightly bench | tee output.txt exit code 0 will be returned if cargo exit with an error, because tee has exit successful. So github action continue after the error and does not fail.

@LuckyTurtleDev
Copy link
Author

The readme/example should suggest

- name: Run benchmark
        run: |
          set -eo pipefail
          cargo +nightly bench | tee output.txt

instead of

- name: Run benchmark
        run:  cargo +nightly bench | tee output.txt

Same for the other languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@LuckyTurtleDev and others