We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, when specifying the alert threshold e.g. alert-threshold: '200%' we cannot specify the metric which we want to alert on.
alert-threshold: '200%'
For instance Go toolchain reports the following metrics:
This action compares the first metric - ns per benchmark - which might be flaky e.g. on some CI systems.
This issue is a feature request to allow alerts on different metrics.
The text was updated successfully, but these errors were encountered:
hey @pmalek, i'm not an owner of this repo but I have a Go project and AFAIK this is not true. This action compares all 3 metrics that you mentioned. Example: https://github.com/openfga/openfga/actions/runs/7302898086
Also, why would ns/op be flaky? You need to make sure that in your setup you compare benchmarks across same CPUs.
ns/op
Sorry, something went wrong.
I'm running the benchmarks on Github provided runners and those seem to differ across runs
Ah yes, that is true. Since you are publishing raw results maybe you need to publish them per CPU 🤔 🤷♀️ I don't know
No branches or pull requests
Currently, when specifying the alert threshold e.g.
alert-threshold: '200%'
we cannot specify the metric which we want to alert on.For instance Go toolchain reports the following metrics:
This action compares the first metric - ns per benchmark - which might be flaky e.g. on some CI systems.
This issue is a feature request to allow alerts on different metrics.
The text was updated successfully, but these errors were encountered: