Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying alerts on metrics different than CPU #206

Open
pmalek opened this issue Dec 11, 2023 · 3 comments
Open

Allow specifying alerts on metrics different than CPU #206

pmalek opened this issue Dec 11, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@pmalek
Copy link

pmalek commented Dec 11, 2023

Currently, when specifying the alert threshold e.g. alert-threshold: '200%' we cannot specify the metric which we want to alert on.

For instance Go toolchain reports the following metrics:

  • ns per benchmark
  • Bytes allocated per benchmark
  • allocations per benchmark

This action compares the first metric - ns per benchmark - which might be flaky e.g. on some CI systems.

This issue is a feature request to allow alerts on different metrics.

@miparnisari
Copy link
Contributor

miparnisari commented Dec 29, 2023

This action compares the first metric - ns per benchmark - which might be flaky e.g. on some CI systems.

hey @pmalek, i'm not an owner of this repo but I have a Go project and AFAIK this is not true. This action compares all 3 metrics that you mentioned. Example: https://github.com/openfga/openfga/actions/runs/7302898086

Also, why would ns/op be flaky? You need to make sure that in your setup you compare benchmarks across same CPUs.

@pmalek
Copy link
Author

pmalek commented Jan 2, 2024

Also, why would ns/op be flaky? You need to make sure that in your setup you compare benchmarks across same CPUs.

I'm running the benchmarks on Github provided runners and those seem to differ across runs

image

@miparnisari
Copy link
Contributor

I'm running the benchmarks on Github provided runners and those seem to differ across runs

Ah yes, that is true. Since you are publishing raw results maybe you need to publish them per CPU 🤔 🤷‍♀️ I don't know

@ktrz ktrz added the enhancement New feature or request label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants