New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question regarding calculation of percentages in the README #207

Open

dafeda opened this issue Dec 27, 2023 · 0 comments

Labels

dafeda commented Dec 27, 2023

README states the following:

By default, this action marks the result as performance regression when it is worse than the previous
exceeding 200% threshold. For example, if the previous benchmark result was 100 iter/ns and this time
it is 230 iter/ns, it means 230% worse than the previous and an alert will happen. The threshold can
be changed by `alert-threshold` input.

Should this be ns/iter and not iter/ns as 230 iter/ns is better than 100 iter/ns?
Also, going from 100 ns/iter to 230 ns/iter is a 130% decrease and not 230% right?

The text was updated successfully, but these errors were encountered:

ktrz added the documentation label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment