Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch2 v.3.5.0 parsing: reTestCaseStart regex #241

Closed
wwerkk opened this issue May 2, 2024 · 1 comment · Fixed by #247
Closed

Catch2 v.3.5.0 parsing: reTestCaseStart regex #241

wwerkk opened this issue May 2, 2024 · 1 comment · Fixed by #247
Labels
bug Something isn't working

Comments

@wwerkk
Copy link

wwerkk commented May 2, 2024

From v3.5.0 onwards, Catch2 prints est run time instead of estimated in the bench header, which results in current Catch2 parser throwing: Error: No benchmark found for bench suite. Possibly mangled output from Catch2:
https://github.com/catchorg/Catch2/blob/v3.5.0/src/catch2/reporters/catch_reporter_console.cpp#L398
ktrz added a commit that referenced this issue May 19, 2024
@ktrz
fix: Catch2 v.3.5.0 changed output format [#241]
fc8cd68 
* update catch2 version
ktrz added a commit that referenced this issue May 19, 2024
@ktrz
fix: Catch2 v.3.5.0 changed output format [#241]
65bdc48 
* fix catch2_bench.cpp file
ktrz added a commit that referenced this issue May 19, 2024
@ktrz
fix: Catch2 v.3.5.0 changed output format [#241]
c40f623 
* fix catch2_bench.cpp file
ktrz added a commit that referenced this issue May 19, 2024
@ktrz
fix: Catch2 v.3.5.0 changed output format [#241]
b481d47 
* fix catch2_bench.cpp file
ktrz added a commit that referenced this issue May 19, 2024
@ktrz
fix: Catch2 v.3.5.0 changed output format [#241]
e32befd 
* add test case for catch2 v3
* modify extract header regexp to work with v3
ktrz added a commit that referenced this issue May 19, 2024
@ktrz
fix: Catch2 v.3.5.0 changed output format [#241]
91e0303 
* revert changes to old catch2 example
* add new catch2 v3 example
@ktrz ktrz mentioned this issue May 19, 2024
Merged
@ktrz ktrz closed this as completed in #247 May 19, 2024
@ktrz ktrz added the bug Something isn't working label May 19, 2024
@ktrz
Copy link
Member

ktrz commented May 19, 2024

released in v1.20.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Catch2 v.3.5.0 changed output format benchmark-action/github-action-benchmark
2 participants
@ktrz @wwerkk