Revert "Remove distutils fallback and outdated comment (#269)" #304
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d5efa74. The original intention of providing a distutils fallback has not gone away. These three extra lines will almost never be used, as most people have setuptools or install with pip anyway, and at the same time it serves as a very low-maintenance solution for people who *do* want to bootstrap setuptools. Bootstrapping setuptools without vendored six (and pyparsing) is a valid use case. Although setuptools by default ships with vendored dependencies, it supports removing the contents of the _vendored/ directory and falling back to an installed version of six.py -- and thirdparty vendors of setuptools, such as Arch Linux and OpenSUSE, actually make use of this and need to be able to bootstrap the dependency tree of setuptools itself.
benjaminp
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d5efa74.
The original intention of providing a distutils fallback has not gone away. These three extra lines will almost never be used, as most people have setuptools or install with pip anyway, and at the same time it serves as a very low-maintenance solution for people who do want to bootstrap setuptools.
Bootstrapping setuptools without vendored six (and pyparsing) is a valid use case. Although setuptools by default ships with vendored dependencies, it supports removing the contents of the _vendored/ directory and falling back to an installed version of six.py -- and thirdparty vendors of setuptools, such as Arch Linux and OpenSUSE, actually make use of this and need to be able to bootstrap the dependency tree of setuptools itself.
@jaraco @jdufresne
See also pyparsing/pyparsing#133