Added value not false check when assigning root for package #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
reviewed
Aug 3, 2018
src/tuple.js
Outdated
| @@ -29,7 +29,7 @@ export { tuple }; | |||
| // object, there's no reliable way to get the global object across all JS | |||
| // environments without using the `Function` constructor, so instead we | |||
| // use the global `Array` constructor as a shared namespace. | |||
| const root = globalKey in Array | |||
| const root = globalKey in Array && Array[globalKey] | |||
| ? Array[globalKey] | |||
| : def(Array, globalKey, new UniversalWeakMap, false); | |||
There was a problem hiding this comment.
Perhaps this could just be
const root = Array[globalKey] ||
def(Array, globalKey, new UniversalWeakMap, false);since the value of the property is always truthy once we've defined it?
|
Definitely more elegant!
…On Sat, Aug 4, 2018, 02:47 Ben Newman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/tuple.js
<#3 (comment)>:
> @@ -29,7 +29,7 @@ export { tuple };
// object, there's no reliable way to get the global object across all JS
// environments without using the `Function` constructor, so instead we
// use the global `Array` constructor as a shared namespace.
-const root = globalKey in Array
+const root = globalKey in Array && Array[globalKey]
? Array[globalKey]
: def(Array, globalKey, new UniversalWeakMap, false);
Perhaps this could just be
const root = Array[globalKey] ||
def(Array, globalKey, new UniversalWeakMap, false);
since the value of the property is always truthy once we've defined it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFLY22hpjrrTz44zDh4Ugx-QECldEGa5ks5uNOD-gaJpZM4VuuSp>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2