[Fix] newline-after-import: recognize decorators
#1139
Conversation
|
@ljharb, done |
|
@ljharb, sorry for my mistake - it's my first test cases for ESLint :) done |
| { | ||
| code : `// issue 1004 | ||
| import foo from 'foo';\n | ||
| @SomeDecorator(foo) |
There was a problem hiding this comment.
hm, if a newline is required after import, this should be invalid - there needs to be a blank line between the import line and the decorator.
| { | ||
| code : `// issue 1004 | ||
| const foo = require('foo');\n | ||
| @SomeDecorator(foo) |
| `, | ||
| output: `// issue 10042 | ||
| import foo from 'foo';\n | ||
| @SomeDecorator(foo) |
There was a problem hiding this comment.
this should autofix to add a blank line above the decorator
| `, | ||
| output: `// issue 1004 | ||
| const foo = require('foo');\n | ||
| @SomeDecorator(foo) |
There was a problem hiding this comment.
this should autofix to add a blank line above the decorator
| @@ -349,5 +359,27 @@ ruleTester.run('newline-after-import', require('rules/newline-after-import'), { | |||
| parserOptions: { sourceType: 'module' }, | |||
| parser: 'babel-eslint', | |||
| }, | |||
| { | |||
| code: `// issue 10042\nimport foo from 'foo';\n@SomeDecorator(foo)\nexport default class Test {}`, | |||
There was a problem hiding this comment.
can these be reverted to use actual newlines instead of \n? it's much more readable.
|
ping @atos1990, this also needs a rebase |
|
@atos1990, please rebase |
|
Came here looking for this fix. ETA on merge? With this rule not working with decorators, it pretty much means it won't work with any of my ts files in Angular, which is the only thing I'm using ESLint for. |
ljharb
changed the title
newline-after-import: recognize decorators
|
thanks @ljharb |
|
We continue with this error in the latest version, I am thinking that the next version could contain this fix, is it right? |
|
Yes. |
|
still don't see this fix in |
|
@skoblenick as you can see if you click on the commit that closed the PR, it is in both main, and every version v2.21.0 and later. |
Hi, this is my fix issue #1004