Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support parseForESLint from custom parser #1435

Merged
merged 1 commit into from Aug 5, 2019
Merged

feat: support parseForESLint from custom parser #1435

merged 1 commit into from Aug 5, 2019

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented Aug 3, 2019

close #1433

@JounQin JounQin mentioned this pull request Aug 3, 2019
Closed
@coveralls
Copy link

coveralls commented Aug 3, 2019 •
edited

Coverage Status

Coverage increased (+2.6%) to 97.897% when pulling 35a12f9 on JounQin:feat/parse_for_eslint into ebcf17c on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.897% when pulling b3cb239 on JounQin:feat/parse_for_eslint into 989f6cc on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.897% when pulling b3cb239 on JounQin:feat/parse_for_eslint into 989f6cc on benmosher:master.

@cdfa
Copy link

cdfa commented Aug 3, 2019

So I ran npm i -D JounQin/eslint-plugin-import#feat/parse_for_eslint, but it's not working. I looked for the utlis/parse.js file you modified and it seems to be located at node_modules/eslint-module-utils/parse.js, but it doesn't have your patch. How do I test it?

@JounQin
Copy link
Collaborator Author

JounQin commented Aug 3, 2019

@cdfa There is no need to wait for this PR, I've exported parse from @rxts/eslint-plugin-mdx, you can simply upgrade to the latest version.

@cdfa
Copy link

cdfa commented Aug 3, 2019

Ah great!

ljharb
ljharb reviewed Aug 3, 2019
View reviewed changes
tests/src/core/parse.js Outdated Show resolved Hide resolved
utils/parse.js Outdated Show resolved Hide resolved
ljharb
ljharb approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljharb ljharb merged commit 35a12f9 into import-js:master Aug 5, 2019
@JounQin JounQin deleted the feat/parse_for_eslint branch August 5, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse error in mdx files
4 participants
@JounQin @coveralls @cdfa @ljharb